[PATCH v1 0/1] arm: dts: modify Nuvoton NPCM750 device tree

Tomer Maimon tmaimon77 at gmail.com
Wed Apr 4 21:15:14 AEST 2018


On 29 March 2018 at 23:37, Arnd Bergmann <arnd at arndb.de> wrote:

> On Mon, Mar 26, 2018 at 12:11 PM, Tomer Maimon <tmaimon77 at gmail.com>
> wrote:
> > The NPCM7xx are a family of BMC's that include several chips as:
> > NPCM750, NPCM730 etc.
> >
> > All of the NPCM7xx BMC's have the common modules like Cortex-A9,
> > WDT, timers, etc, and there are a optional modules that can be added.
> >
> > NPCM750 device tree already pushed to arm-soc.git:
> > https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-
> soc.git/commit/?h=for-next&id=d6bdd009c21db3f677dd1d1bbb8c20bc819074bc
> >
> > After discussion with Rob Herring we have modified the structure
> > of the NPCM7xx device tree as follow:
> >
> > nuvoton-common-npcm7xx device tree include all common modules
> > nuvoton-npcm750 device tree include specific npcm750 modules,
> > the nuvoton-npcm750 device tree include nuvoton-common-npcm7xx device
> tree
> >
> > In addition, the NPCM7xx device tree include the following changes:
> >         - watchdog module added
> >         - clock module modification
> >         - serial module modification
> >         - Modify Makefile NPCM7XX configuration name
> >
> > Sorry if it cause more work after pushing NPCM750 device tree.
>
> I only see one patch here, which fails to describe the changes and
> combines all of the above changes into one commit.
>
> Please follow the usual style for sending patches and do one thing
> at a time. In particular, never move large parts of a file code around
> in a patch that also contains other changes, those need to be split
> up. Each patch should also have a description that explains what
> it's for.
>
>        Arnd
>

sent again (split patches)

Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20180404/1d3b3f20/attachment-0001.html>


More information about the openbmc mailing list