[PATCH linux dev-4.10] drivers: fsi: occ: Fix errno for canceling a read operation

Eddie James eajames at linux.vnet.ibm.com
Fri Oct 13 02:59:53 AEDT 2017


From: "Edward A. James" <eajames at us.ibm.com>

Should not return -ECANCELED when the device has been removed. Instead,
use -ENODEV.

Signed-off-by: Edward A. James <eajames at us.ibm.com>
---
 drivers/fsi/occ.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/fsi/occ.c b/drivers/fsi/occ.c
index 2e64ee2..1fe1a54 100644
--- a/drivers/fsi/occ.c
+++ b/drivers/fsi/occ.c
@@ -240,8 +240,10 @@ static ssize_t occ_read_common(struct occ_client *client, char __user *ubuf,
 		spin_lock_irq(&client->lock);
 
 		if (!test_bit(XFR_COMPLETE, &xfr->flags)) {
-			if (occ->cancel || test_bit(XFR_CANCELED, &xfr->flags))
+			if (test_bit(XFR_CANCELED, &xfr->flags))
 				rc = -ECANCELED;
+			else if (occ->cancel)
+				rc = -ENODEV;
 			else
 				rc = -EINTR;
 
-- 
1.8.3.1



More information about the openbmc mailing list