[PATCH linux dev-4.10 1/1] arm: dts: Add Wfp BMC Machine

James Feist james.feist at linux.intel.com
Tue Nov 14 11:02:16 AEDT 2017


On 11/13/2017 03:43 PM, Joel Stanley wrote:
> On Tue, Nov 14, 2017 at 4:16 AM, James Feist
> <james.feist at linux.intel.com> wrote:
>> On 11/12/2017 11:36 PM, Joel Stanley wrote:
>>>
>>> This is the same as aspeed-bmc-opp-flash-layout.dtsi. Is there any
>>> reason we can't reuse that file?
>>>
>>
>> We could, however it seems a bit awkward to have this platform lumped in
>> with open power, as it is not an open power platform. Also if we decide to
>> modify the flash layout then this would have to be done anyways. I am fine
>> either way, it just seemed to make more sense having them separate. Another
>> alternative would be to rename aspeed-bmc-opp-flash-layout.dtsi to something
>> more openbmc related instead of openpower.
> 
> I'd be happy to accept a patch that renames it. I was never a fan of
> the opp string in the device tree files; it's namespacing that
> upstream dts and dtsi tend not to have.
> 
> Cheers,
> 
> Joel
> 
Does aspeed-bmc-phosphor-flash-layout.dtsi sound reasonable?

Thanks,

James


More information about the openbmc mailing list