[PATCH] witherspoon: leds: Use underscore in led names than hyphen

Jeremy Kerr jk at ozlabs.org
Wed May 17 10:53:38 AEST 2017


Hi Vishwa,

[reply-to-all this time, sorry for the duplicate, Vishwa]

> --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> @@ -50,15 +50,15 @@
>  	leds {
>  		compatible = "gpio-leds";
>  
> -		rear-fault {
> +		rear_fault {
>  			gpios = <&gpio ASPEED_GPIO(N, 2) GPIO_ACTIVE_LOW>;
>  		};

This is somewhat contrary to device-tree convention, where nodes (and
properties, and compatible values) are generally hyphen-separated.

Can we deal with this another way? Perhaps we can use the '%I' specifier
in the systemd unit file, which bypasses the escaping?

Cheers,


Jeremy


More information about the openbmc mailing list