[PATCH] witherspoon: leds: Use underscore in led names than hyphen
Vishwanatha Subbanna
vishwa at linux.vnet.ibm.com
Wed May 10 19:10:11 AEST 2017
udev rule for leds subsystem in Witherspoon launches a systemd
service file with $devpath. If the devpath is
sys-devices-platform-leds-leds-rear-fault, systemd service file
interprets it as /sys/devices/platform/leds/leds/rear/fault.
However, what is really needed by the service file is
/sys/devices/platform/leds/leds/rear-fault.
This is a limitation in current systemd with template argument
containing hyphen. Short term solution is to have $name contain
underscores.
It would then become: /sys/devices/platform/leds/leds/rear_fault
and hence will work.
Refer systemd bug: https://github.com/systemd/systemd/issues/5072
Change-Id: Ie45dbf92e5ea96b8d8461856415bae6ce0bbd7d8
Signed-off-by: Vishwanatha Subbanna <vishwa at linux.vnet.ibm.com>
---
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
index ca228be..da0ff4a 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
@@ -50,15 +50,15 @@
leds {
compatible = "gpio-leds";
- rear-fault {
+ rear_fault {
gpios = <&gpio ASPEED_GPIO(N, 2) GPIO_ACTIVE_LOW>;
};
- rear-id {
+ rear_id {
gpios = <&gpio ASPEED_GPIO(N, 4) GPIO_ACTIVE_LOW>;
};
- rear-power {
+ rear_power {
gpios = <&gpio ASPEED_GPIO(N, 3) GPIO_ACTIVE_LOW>;
};
};
--
1.9.1
More information about the openbmc
mailing list