[PATCH linux dev-4.7] arm: configs: aspeed: Disable CONFIG_MTD_SPI_NOR_USE_4K_SECTORS

[Joel Stanley]

On Thu, May 11, 2017 at 7:31 AM, Adriana Kobylak
<anoo at linux.vnet.ibm.com> wrote:
> Milton stopped by and mentioned that you had tried to modify the 4K erase
> sector previously for a perhaps bmc chip and saw some flash corruption when
> moving to an image that changed it?
>
> Just wanted to add that this change only changes the pnor setting and I
> didn’t see any issues powering on a system after updating the BMC with an
> image with this change. Then I updated the pnor with an image that had the
> mbox enabled. Also checked with AndrewJ and the hostboot team and there’s no
> hard-coded assumptions in their side about the erase size.
>
> With all this info let me know if you have any thoughts or concerns.

I recall issues relating to this option. I didn't record what they were though.

Cedric, can you remind me what the issues are with the 4K kconfig option?

Cheers,

Joel

>
> Thanks!
>
>
> Begin forwarded message:
>
> From: Adriana Kobylak <anoo at linux.vnet.ibm.com>
> Subject: [PATCH linux dev-4.7] arm: configs: aspeed: Disable
> CONFIG_MTD_SPI_NOR_USE_4K_SECTORS
> Date: May 4, 2017 at 10:58:07 AM CDT
> To: openbmc at lists.ozlabs.org
> Cc: Adriana Kobylak <anoo at linux.vnet.ibm.com>
>
> Disable the 4KB erase block size from the spi nor to be able to
> use UBIFS, since UBIFS requires the erase size to be at least 15KB.
>
> Signed-off-by: Adriana Kobylak <anoo at linux.vnet.ibm.com>
> ---
> arch/arm/configs/aspeed_g4_defconfig | 1 +
> arch/arm/configs/aspeed_g5_defconfig | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/arm/configs/aspeed_g4_defconfig
> b/arch/arm/configs/aspeed_g4_defconfig
> index 4350f67..6538993 100644
> --- a/arch/arm/configs/aspeed_g4_defconfig
> +++ b/arch/arm/configs/aspeed_g4_defconfig
> @@ -69,6 +69,7 @@ CONFIG_MTD=y
> CONFIG_MTD_BLOCK=y
> CONFIG_MTD_PARTITIONED_MASTER=y
> CONFIG_MTD_SPI_NOR=y
> +# CONFIG_MTD_SPI_NOR_USE_4K_SECTORS is not set
> CONFIG_ASPEED_FLASH_SPI=y
> CONFIG_MTD_UBI=y
> CONFIG_MTD_UBI_FASTMAP=y
> diff --git a/arch/arm/configs/aspeed_g5_defconfig
> b/arch/arm/configs/aspeed_g5_defconfig
> index b6b3ca0..7063949 100644
> --- a/arch/arm/configs/aspeed_g5_defconfig
> +++ b/arch/arm/configs/aspeed_g5_defconfig
> @@ -68,6 +68,7 @@ CONFIG_MTD=y
> CONFIG_MTD_BLOCK=y
> CONFIG_MTD_PARTITIONED_MASTER=y
> CONFIG_MTD_SPI_NOR=y
> +# CONFIG_MTD_SPI_NOR_USE_4K_SECTORS is not set
> CONFIG_ASPEED_FLASH_SPI=y
> CONFIG_MTD_UBI=y
> CONFIG_MTD_UBI_FASTMAP=y
> --
> 1.8.2.2
>
>