[PATCH linux dev-4.7] drivers/fsi: Remove hub devices during master unregister

[Christopher Bostic]

On 3/6/17 8:37 PM, Joel Stanley wrote:
> On Tue, Mar 7, 2017 at 11:25 AM, Christopher Bostic
> <cbostic at linux.vnet.ibm.com> wrote:
>> +static int fsi_unregister_hubs(struct device *dev, void *data)
>> +{
>> +       struct fsi_master_hub *hub =
>> +                               (struct fsi_master_hub *)dev_get_drvdata(dev);
>> +
>> +       if (!hub)
>> +               return 0;
>> +
>> +       device_del(dev);
>> +       fsi_master_unscan(&hub->master);
>> +}
> This introduces a warning:
>
> drivers/fsi/fsi-core.c: In function ‘fsi_unregister_hubs’:
> drivers/fsi/fsi-core.c:754:1: warning: control reaches end of non-void
> function [-Wreturn-type]
>   }
>   ^
>
> Did you build test this patch?
I did build but didn't see the warning. Wasn't looking close enough 
apparently -will correct.

> Have you boot tested it?

I did boot it.
> What runtime testing did you perform?
I ran multiple scans without rebooting to verify the removal and 
creation of sysfs files was done properly.
Also verified no further sysfs warnings attempting to create duplicate 
file names.



> Cheers,
>
> Joel
>