[PATCH linux dev-4.7] drivers/fsi: Remove hub devices during master unregister

Joel Stanley joel at jms.id.au
Tue Mar 7 13:37:05 AEDT 2017


On Tue, Mar 7, 2017 at 11:25 AM, Christopher Bostic
<cbostic at linux.vnet.ibm.com> wrote:
>
> +static int fsi_unregister_hubs(struct device *dev, void *data)
> +{
> +       struct fsi_master_hub *hub =
> +                               (struct fsi_master_hub *)dev_get_drvdata(dev);
> +
> +       if (!hub)
> +               return 0;
> +
> +       device_del(dev);
> +       fsi_master_unscan(&hub->master);
> +}

This introduces a warning:

drivers/fsi/fsi-core.c: In function ‘fsi_unregister_hubs’:
drivers/fsi/fsi-core.c:754:1: warning: control reaches end of non-void
function [-Wreturn-type]
 }
 ^

Did you build test this patch?

Have you boot tested it?

What runtime testing did you perform?

Cheers,

Joel


More information about the openbmc mailing list