[PATCH linux dev-4.10] aspeed-g5: add gpiolib irqchip support.

Andrew Jeffery andrew at aj.id.au
Fri Jun 30 16:23:45 AEST 2017

On Fri, 2017-06-30 at 04:44 +0000, Vadim Pasternak wrote:
> > Sorry, I don't understand the need for this; CONFIG_GPIOLIB_IRQCHIP is
> > already selected by CONFIG_GPIO_ASPEED, which is enabled by the
> > aspeed_g5_defconfig. I don't think we need to do this here.
> > 
> > Further, what problem are you trying to solve? From my testing GPIO
> > interrupts are functional.
> > 
> We have the number of CPLDs with the internal interrupt control
> logic. Interrupts on top routed through the particular GPIO to SoC.
> The motivation was to specify top aggregation interrupt for CPLD
> driver in DTS with GPIO pin number and convert it in driver with
> gpio_to_irq and connect irq to CPLD interrupt handler.

Okay; you'll likely want to use gpio*d*_to_irq(), as gpio_to_irq() is
part of the legacy GPIO infrastructure. It doesn't look like you need
GENERIC_IRQ_CHIP to access gpiod_to_irq(), the existing GPIOLIB
dependency should be enough.

If we did need configuration changes, my preference would be to put
them in a defconfig rather than in the arch Kconfig.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20170630/47eb8248/attachment.sig>

More information about the openbmc mailing list