[PATCH linux dev-4.10 v2] ARM: dts: aspeed: quanta: Enable pwm fans

Joel Stanley joel at jms.id.au
Thu Jun 29 08:48:20 AEST 2017

On Wed, Jun 28, 2017 at 11:31 PM, Patrick Venture <venture at google.com> wrote:

>>> +               compatible = "aspeed,ast2500-pwm-tacho";
>>> +               clocks = <&pwm_tacho_fixed_clk>;
>>> +               pinctrl-names = "default";
>>> +               pinctrl-0 = <&pinctrl_pwm0_default &pinctrl_pwm1_default
>>> +                       &pinctrl_pwm2_default &pinctrl_pwm3_default>;
>> It looks like you're using fans 0..7, but you're only requesting the
>> pins for the first four fans. Should you be requesting all 8?
> The pwm actually drives a pair on this board.  So, we have 8 fans, but
> only four active pwm controls.  I don't know if this is a driver issue
> but the fans are paired and work as a pair.

Okay. The bindings are a bit confusing at first glance. Sounds like
you've got it under control.

I'll apply your v3.



More information about the openbmc mailing list