[PATCH] drivers/misc: add Aspeed LPC snoop driver

Arnd Bergmann arnd at arndb.de
Tue Jun 6 18:07:32 AEST 2017


On Tue, Jun 6, 2017 at 4:16 AM, Joel Stanley <joel at jms.id.au> wrote:
> On Tue, Jun 6, 2017 at 5:16 AM, Rob Lippert <rlippert at google.com> wrote:
>> On Sun, Jun 4, 2017 at 8:25 PM, Joel Stanley <joel at jms.id.au> wrote:
>
> Yeah, get_maintainers.pl only suggested lkml. cc lkml I think.
>
> I'm not sure if we want to put these drivers in misc, or if we want to
> use something like drivers/soc/aspeed.
>
> Arnd, Greg, do you have any suggestions here?

I think the main question is whether there are going to be other drivers
like this one. Are there any other BMCs that still survive on the market
with an LPC slave port? The only other ones I have seen were the
old Broadcom one (apparently discontinued when Broadcom acquired
the Emulex BMC line) and those Emulex BMCs (now part of ASpeed,
presumably merged with the other product line) and some obscure
Nuvoton product I could not find out much about.

If we do expect more drivers like this, I'd put it into a new drivers/lpc
directory (which we might use for both slave and master drivers,
at least one master driver is pending merge), otherwise drivers/bus/
or drivers/soc/ would be better.

Between the last two, I'm not sure, since this still doesn't fit perfectly
in one or the other, but both would work.

        Arnd


More information about the openbmc mailing list