[PATCH] drivers/misc: add Aspeed LPC snoop driver
gregkh at linuxfoundation.org
Tue Jun 6 15:35:31 AEST 2017
On Tue, Jun 06, 2017 at 11:46:56AM +0930, Joel Stanley wrote:
> On Tue, Jun 6, 2017 at 5:16 AM, Rob Lippert <rlippert at google.com> wrote:
> > On Sun, Jun 4, 2017 at 8:25 PM, Joel Stanley <joel at jms.id.au> wrote:
> >> Hello Rob,
> >> On Sat, Jun 3, 2017 at 7:23 AM, Robert Lippert <roblip at gmail.com> wrote:
> >>> This driver enables the LPC snoop hardware on the ASPEED BMC
> >>> which generates an interrupt upon every write to an I/O port
> >>> by the host.
> >>> This is typically used to monitor BIOS boot progress by listening
> >>> to well-known debug port 80h.
> >>> The functionality in this commit just saves all snooped values
> >>> to a circular 2K buffer in the kernel, subsequent commits can
> >>> act on the values to do things with them.
> >> Reviewed-by: Joel Stanley <joel at jms.id.au>
> >> The driver looks okay to me. I can stage it in the OpenBMC kernel tree
> >> while we get it reviewed upstream.
> >> Can you re-send to the upstream mailing lists so it gets reviewed
> >> there. You will need to include a device tree binding document too
> >> (something to put in Documentation/devicetree/bindings/).
> > What is the proper upstream mailing list for this? patman didn't list
> > any mailing lists...
> Yeah, get_maintainers.pl only suggested lkml. cc lkml I think.
> I'm not sure if we want to put these drivers in misc, or if we want to
> use something like drivers/soc/aspeed.
> Arnd, Greg, do you have any suggestions here?
It's up to you :)
More information about the openbmc