[PATCH linux dev-4.10 0/6] Hardware work-arounds for max31785

George Keishing gkeishin at in.ibm.com
Sun Jul 30 02:09:49 AEST 2017

Tested-by: George Keishing    <gkeishin at in.ibm.com >

Thanks and Regards,
   George Keishing
   IBM Systems &Technology Lab, Firmware Development,
“ There isn't enough time in a day to be lazy!!! .”

From: Andrew Jeffery <andrew at aj.id.au>
Date: Fri, Jul 28, 2017 at 11:22 AM
Subject: [PATCH linux dev-4.10 0/6] Hardware work-arounds for max31785
To: joel at jms.id.au
Cc: Andrew Jeffery <andrew at aj.id.au>, openbmc at lists.ozlabs.org


Two issues have reared up regarding the recently applied MAX31785 driver:

The first issue, regarding unexpected NACKs from the device, was 
discovered in
earlier testing but its impact wasn't clear and its cause was not nailed 
at the time. The thought was it could be solved in slow-time, but this 
out not to be the case. A work-around is presented in the last patch.

The second issue stems from a difference in hardware behaviour between
Witherspoon hardware levels. Integration testing machines do not have the
"installed" bit programmed into the max31785 chip out of the box, whilst 
appears that functional testing level machines do. The consequence is the
driver emitted some warnings and exposed none of the fans to userspace on 
level machines. A new devicetree property is added to make the driver 
the installed bits in the max31785 chip during initialisation.

Please review.


Andrew Jeffery (6):
  dt-bindings: max31785: Add mark-fan-installed property
  ARM: dts: aspeed: Configure Firestone to mark its fans as installed
  ARM: dts: aspeed: Configure Romulus to mark its fans as installed
  ARM: dts: aspeed: Configure Witherspoon to mark its fans as installed
  max31785: Support mark-fan-installed devicetree property
  pmbus: max31785: Work around back-to-back writes with FAN_CONFIG_1_2

 .../devicetree/bindings/hwmon/pmbus/max31785.txt   |   2 +
 arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts     |   6 ++
 arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts       |   6 ++
 arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts   |   4 +
 drivers/hwmon/pmbus/max31785.c                     | 116 
 5 files changed, 123 insertions(+), 11 deletions(-)


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20170729/3ac36716/attachment.html>

More information about the openbmc mailing list