<font size=2 face="sans-serif">Tested-by: George Keishing <gkeishin@in.ibm.com
></font><br><br><font size=2 color=blue face="sans-serif"><b>Thanks and Regards,</b></font><br><font size=2 color=blue face="sans-serif"> George Keishing</font><br><font size=2 color=blue face="sans-serif"> IBM Systems
&Technology Lab, Firmware Development,</font><br><font size=2 face="sans-serif"><i>“</i></font><font size=3> There
isn't enough time in a day to be lazy!!! </font><font size=1 face="sans-serif">.”</font><br><br><tt><font size=2><br>From: Andrew Jeffery <andrew@aj.id.au><br>Date: Fri, Jul 28, 2017 at 11:22 AM<br>Subject: [PATCH linux dev-4.10 0/6] Hardware work-arounds for max31785<br>To: joel@jms.id.au<br>Cc: Andrew Jeffery <andrew@aj.id.au>, openbmc@lists.ozlabs.org<br><br><br>Hello,<br><br>Two issues have reared up regarding the recently applied MAX31785 driver:<br><br>The first issue, regarding unexpected NACKs from the device, was discovered
in<br>earlier testing but its impact wasn't clear and its cause was not nailed
down<br>at the time. The thought was it could be solved in slow-time, but this
turned<br>out not to be the case. A work-around is presented in the last patch.<br><br>The second issue stems from a difference in hardware behaviour between<br>Witherspoon hardware levels. Integration testing machines do not have the<br>"installed" bit programmed into the max31785 chip out of the
box, whilst it<br>appears that functional testing level machines do. The consequence is the<br>driver emitted some warnings and exposed none of the fans to userspace
on ITC<br>level machines. A new devicetree property is added to make the driver configure<br>the installed bits in the max31785 chip during initialisation.<br><br>Please review.<br><br>Andrew<br><br>Andrew Jeffery (6):<br> dt-bindings: max31785: Add mark-fan-installed property<br> ARM: dts: aspeed: Configure Firestone to mark its fans as installed<br> ARM: dts: aspeed: Configure Romulus to mark its fans as installed<br> ARM: dts: aspeed: Configure Witherspoon to mark its fans as installed<br> max31785: Support mark-fan-installed devicetree property<br> pmbus: max31785: Work around back-to-back writes with FAN_CONFIG_1_2<br><br> .../devicetree/bindings/hwmon/pmbus/max31785.txt | 2 +<br> arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts |
6 ++<br> arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts |
6 ++<br> arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 4 +<br> drivers/hwmon/pmbus/max31785.c
| 116 +++++++++++++++++++--<br> 5 files changed, 123 insertions(+), 11 deletions(-)<br><br>--<br>2.11.0<br><br></font></tt><br><BR>