[PATCH linux dev-4.10 v2 0/8] pmbus: Add MAX31785 driver

Andrew Jeffery andrew at aj.id.au
Thu Jul 27 19:57:09 AEST 2017


This follows up from my initial series and request for testing:


What's changed: I've sent the relevant patches upstream[1], and this series
represents a backport of that upstream work with integration into the OpenBMC
kernel tree. I have also tested with the OpenBMC userspace (particularly, the
interactions with phosphor-hwmon) and pushed a patch to fix the broken piece:


Patches from Joel cover off some of the follow-up notes from v1, namely fixing
the devicetrees for Romulus and Firestone.

There's still an open issue around the causes of some communication issues to
the MAX31785, but it turns out the instability is not a regression and it seems
we don't hit it in practice. Further, the features exposed in the rewrite are
necessary to ensure correct behaviour of the fans: the hwmon-based driver did
not fully configure FAN_COMMAND_1_2, MFR_FAN_CONFIG or MFR_FAULT_RESPONSE as
the systems require. These commands are now all exposed to the devicetree for

Please review!



[1] https://lists.ozlabs.org/pipermail/openbmc/2017-July/008405.html

Andrew Jeffery (6):
  dt-bindings: hwmon: pmbus: Add Maxim MAX31785 documentation
  ARM: dts: aspeed: witherspoon: Update max31785 node
  hwmon: pmbus: Add fan control support
  hwmon: Remove MAX31785 implementation
  pmbus: Add driver for Maxim MAX31785 Intelligent Fan Controller
  ARM: dts: aspeed: Witherspoon has a MAX31785A fan controller

Joel Stanley (2):
  ARM: dts: aspeed: romulus: Update max31785 node
  ARM: dts: aspeed: firestone: Update max31785 node

 .../devicetree/bindings/hwmon/pmbus/max31785.txt   | 117 +++
 arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts     |  84 +-
 arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts       |  80 ++
 arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts   |  59 +-
 drivers/hwmon/Kconfig                              |  10 -
 drivers/hwmon/Makefile                             |   1 -
 drivers/hwmon/max31785.c                           | 893 ---------------------
 drivers/hwmon/pmbus/Kconfig                        |  10 +
 drivers/hwmon/pmbus/Makefile                       |   1 +
 drivers/hwmon/pmbus/max31785.c                     | 670 ++++++++++++++++
 drivers/hwmon/pmbus/pmbus.h                        |  29 +
 drivers/hwmon/pmbus/pmbus_core.c                   | 222 ++++-
 12 files changed, 1252 insertions(+), 924 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/max31785.txt
 delete mode 100644 drivers/hwmon/max31785.c
 create mode 100644 drivers/hwmon/pmbus/max31785.c


More information about the openbmc mailing list