[PATCH linux dev-4.10 0/5] pmbus: Add MAX31785 driver

Andrew Jeffery andrew at aj.id.au
Sat Jul 22 03:51:26 AEST 2017


This is a backport to dev-4.10 of the series I intend to send upstream,
which implements the MAX31785 driver using the PMBus subsystem.

I'd like to see it cook for a bit in the OpenBMC tree to get some confidence
in the implementation (after recent indiscretions).

Some caveats:

1. I've only updated the Witherspoon devicetree. Romulus and Firestone also need
   to be updated, but I'm not sure what configuration they require (it may not
   be too different to Witherspoon). If someone could provide feedback here I
   can send more patches.
2. There may be some userspace breakage around what fans are exposed: Only
   fans configured in the devicetree will have attributes in sysfs, and the
   first and second tach input attributes are always contiguous. That is, if
   only one fan is specified in the devicetree and it is configured as dual
   tach, then the input attributes will be fan1_input and fan2_input.

Anyway please review and test! I've given it a spin on a Witherspoon system and
it looks to be functional. I haven't done much testing with the OpenBMC
userspace to shore up the second issue mentioned above, so that needs further



Andrew Jeffery (5):
  dt-bindings: hwmon: pmbus: Add Maxim MAX31785 documentation
  ARM: aspeed: Update max31785 node in Witherspoon devicetree
  hwmon: pmbus: Add fan control support
  hwmon: Remove MAX31785 implementation
  pmbus: Add driver for Maxim MAX31785 Intelligent Fan Controller

 .../devicetree/bindings/hwmon/pmbus/max31785.txt   | 113 +++
 arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts   |  55 +-
 drivers/hwmon/Kconfig                              |  10 -
 drivers/hwmon/Makefile                             |   1 -
 drivers/hwmon/max31785.c                           | 893 ---------------------
 drivers/hwmon/pmbus/Kconfig                        |  10 +
 drivers/hwmon/pmbus/Makefile                       |   1 +
 drivers/hwmon/pmbus/max31785.c                     | 655 +++++++++++++++
 drivers/hwmon/pmbus/pmbus.h                        |  29 +
 drivers/hwmon/pmbus/pmbus_core.c                   | 222 ++++-
 10 files changed, 1068 insertions(+), 921 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/max31785.txt
 delete mode 100644 drivers/hwmon/max31785.c
 create mode 100644 drivers/hwmon/pmbus/max31785.c


More information about the openbmc mailing list