[PATCH linux dev-4.10 v5] ARM: dts: aspeed: Add gpio-keys-polled for fan presence

Joel Stanley joel at jms.id.au
Thu Jul 27 13:08:22 AEST 2017

On Thu, Jul 27, 2017 at 7:21 AM, Christopher Bostic
<cbostic at linux.vnet.ibm.com> wrote:
> Define gpio-keys-polled.  Add pca-955x chip IO as GPIO source.
> Polling period of 1 second determined to be the max acceptable
> value based on discussions with Brad Bishop and Matt Spinler.
> Signed-off-by: Christopher Bostic <cbostic at linux.vnet.ibm.com>
> ---
> v5 - Fix gpio-keys-polled driver probe errors.  Missing pca955x
>      gpio cells property and wrong format for poll-interval.
> v4 - Add details regarding polling period to commit message.
> v3 - Remove 'autorepeat'
>    - Increase polling period to 1 second.
>    - Remove GPIO specifiers from pca955x in dev tree
> v2 - Change 'linux,code' from a unique global value to a local one
>      for all the gpio-keys-polled devices.

>From off-list:

On Thu, Jul 27, 2017 at 11:41 AM, Christopher Bostic
<cbostic at linux.vnet.ibm.com> wrote:
>> Even after these probe fixes something more is needed.  I tried a bunch
>> of stuff but I could not get the input subsys device created by
>> gpio-keys to work, for these gpios.  I ran strace on my test app here:
>> https://github.com/bradbishop/gpio-keys
>> and it seems like I’m getting ENOENT back on one of the ioctls.  Do you
>> have some
>> time to dig into this?
> I'll have a look at the ioctl issue.
> Thanks,
> Chris

I will hold off on merging this patch until it has been tested.



More information about the openbmc mailing list