[PATCH linux dev-4.10 2/2] ARM: dts: aspeed: firestone: Request UART pins

Andrew Jeffery andrew at aj.id.au
Tue Jul 25 14:14:26 AEST 2017


On Tue, 2017-07-25 at 13:42 +0930, Andrew Jeffery wrote:
> On Mon, 2017-07-24 at 21:39 +0930, Joel Stanley wrote:
> > Signed-off-by: Joel Stanley <joel at jms.id.au>
> 
> Reviewed-by: Andrew Jeffery <andrew at aj.id.au>

On the condition that you add 'pinctrl-names = "default";' to both
nodes.

Thought popped into my head literally moments after I hit send.

> 
> > ---
> >  arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> > index cc479efd1763..39a836cbdfa5 100644
> > --- a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> > @@ -75,10 +75,28 @@
> >  
> >  &uart1 {
> > >  	status = "okay";
> > 
> > +
> > > > > > +	pinctrl-0 = <&pinctrl_txd1_default
> > > > > > +			&pinctrl_rxd1_default
> > > > > > +			&pinctrl_nrts1_default
> > > > > > +			&pinctrl_ndtr1_default
> > > > > > +			&pinctrl_ndsr1_default
> > > > > > +			&pinctrl_ncts1_default
> > > > > > +			&pinctrl_ndcd1_default
> > > +			&pinctrl_nri1_default>;
> > 
> >  };
> >  
> >  &uart2 {
> > >  	status = "okay";
> > 
> > +
> > > > > > +	pinctrl-0 = <&pinctrl_txd2_default
> > > > > > +			&pinctrl_rxd2_default
> > > > > > +			&pinctrl_nrts2_default
> > > > > > +			&pinctrl_ndtr2_default
> > > > > > +			&pinctrl_ndsr2_default
> > > > > > +			&pinctrl_ncts2_default
> > > > > > +			&pinctrl_ndcd2_default
> > > +			&pinctrl_nri2_default>;
> > 
> >  };
> >  
> >  &uart5 {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20170725/24bbf8a5/attachment.sig>


More information about the openbmc mailing list