[PATCH linux dev-4.10 1/2] ARM: dts: aspeed: firestone: Fix i2c addresses

[Andrew Jeffery]

On Mon, 2017-07-24 at 21:39 +0930, Joel Stanley wrote:
> With the 10 bit addresses we fail to probe.
> 
> After this change, the drivers correctly probe on a Firestone system
> with this
> kernel.
> 
> Signed-off-by: Joel Stanley <joel at jms.id.au>
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> index fef73ea7fd0c..cc479efd1763 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> @@ -124,7 +124,7 @@
>  
>  	tmp423 at 98 {

We should fix the node name as well. Applies to any other instances
below.	

>  		compatible = "ti,tmp423";
> -		reg = <0x80000098>;
> +		reg = <0x4c>;
>  	};
>  };
>  
> @@ -139,7 +139,7 @@
>  
>  	tmp423 at 98 {
>  		compatible = "ti,tmp423";
> -		reg = <0x80000098>;
> +		reg = <0x4c>;

>  	};
>  };
>  
> @@ -171,7 +171,7 @@
>  
>  	leds at c0 {
>  		compatible = "pca,pca9552led";
> -		reg = <0x800000c0>;
> +		reg = <0x60>;
>  		// led9 - led_fault_n
>  		// led10 - pwr_led_n
>  		// led11 - rear_id_led_n
> @@ -179,21 +179,21 @@
>  
>  	rtc at d0 {
>  		compatible = "dallas,ds3231";
> -		reg = <0x800000d0>;
> +		reg = <0x68>;
>  	};
>  
>  	si5338a at e2 {
>  		// SiLabs clock generator
> -		reg =<0x800000e2>;
> +		reg =<0x71>;
>  	};
>  
>  	idt at d6 {
>  		// IDT 9DBV0641 clock buffer
> -		reg = <0x800000d6>;
> +		reg = <0x6b>;
>  	};
>  
>  	tpm at a3 {
> -		reg = <0x800000a3>;

This is weird though right? Usually the 0th bit is cleared (7 bits
counted from the 7th bit, 0th bit ignored), but in this case it's set.
Seems something was broken with the address to start with?

> +		reg = <0x51>;

So is this the right address?

>  	};
>  };
>  
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20170725/f1372932/attachment.sig>