[PATCH linux dev-4.10] msn: add adc to msn dts.

Mykola Kostenok c_mykolak at mellanox.com
Tue Jul 11 01:07:50 AEST 2017


Hi, Rick.
Thank you for pointing that out.
I had another aspeed-adc driver before.

I will send patch v2 with correct bindings.

Best regards. Mykola Kostenok.

From: Rick Altherr [mailto:raltherr at google.com]
Sent: Friday, July 7, 2017 8:17 PM
To: Mykola Kostenok <c_mykolak at mellanox.com>
Cc: Joel Stanley <joel at jms.id.au>; OpenBMC Maillist <openbmc at lists.ozlabs.org>
Subject: Re: [PATCH linux dev-4.10] msn: add adc to msn dts.

This doesn't match the bindings for the Aspeed ADC: https://github.com/openbmc/linux/blob/dev-4.7/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt<https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenbmc%2Flinux%2Fblob%2Fdev-4.7%2FDocumentation%2Fdevicetree%2Fbindings%2Fiio%2Fadc%2Faspeed_adc.txt&data=02%7C01%7Cc_mykolak%40mellanox.com%7Cbb1dcd32fbce4588d8cf08d4c55bf631%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636350446161614183&sdata=Xg4aMhMddCrvBd8S8au0DjWZrRsrgWQB2FO7O0xAKVw%3D&reserved=0>.

On Fri, Jul 7, 2017 at 2:12 AM, Mykola Kostenok <c_mykolak at mellanox.com<mailto:c_mykolak at mellanox.com>> wrote:
Add adc for Mellanox msn platform to dts.

Signed-off-by: Mykola Kostenok <c_mykolak at mellanox.com<mailto:c_mykolak at mellanox.com>>
---
 arch/arm/boot/dts/aspeed-bmc-mellanox-msn.dts | 45 +++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed-bmc-mellanox-msn.dts b/arch/arm/boot/dts/aspeed-bmc-mellanox-msn.dts
index 0774959b1222..462a638e66c6 100644
--- a/arch/arm/boot/dts/aspeed-bmc-mellanox-msn.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-mellanox-msn.dts
@@ -139,3 +139,48 @@
        status = "okay";
 };

+&adc {
+       status = "okay";
+       #address-cells = <1>;
+       #size-cells = <0>;
+       adc1 {
+               channel = <0>;
+               min = <677>;
+               max = <828>;
+       };
+       adc2 {
+               channel = <2>;
+               min = <684>;
+               max = <836>;
+       };
+       adc3 {
+               channel = <3>;
+               min = <684>;
+               max = <836>;
+       };
+       adc4 {
+               channel = <4>;
+               min = <676>;
+               max = <826>;
+       };
+       adc5 {
+               channel = <10>;
+               min = <691>;
+               max = <845>;
+       };
+       adc6 {
+               channel = <11>;
+               min = <640>;
+               max = <782>;
+       };
+       adc7 {
+               channel = <12>;
+               min = <615>;
+               max = <751>;
+       };
+       adc8 {
+               channel = <13>;
+               min = <587>;
+               max = <719>;
+       };
+};
--
2.11.0

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20170710/f4bd6e8d/attachment.html>


More information about the openbmc mailing list