<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.hoenzb
{mso-style-name:hoenzb;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Hi,</span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Rick.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Thank you for pointing that out.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">I had another aspeed-adc driver before.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">I will send patch v2 with correct bindings.</span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Best regards. Mykola Kostenok.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Rick Altherr [mailto:raltherr@google.com]
<br>
<b>Sent:</b> Friday, July 7, 2017 8:17 PM<br>
<b>To:</b> Mykola Kostenok <c_mykolak@mellanox.com><br>
<b>Cc:</b> Joel Stanley <joel@jms.id.au>; OpenBMC Maillist <openbmc@lists.ozlabs.org><br>
<b>Subject:</b> Re: [PATCH linux dev-4.10] msn: add adc to msn dts.<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">This doesn't match the bindings for the Aspeed ADC: <a href="https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenbmc%2Flinux%2Fblob%2Fdev-4.7%2FDocumentation%2Fdevicetree%2Fbindings%2Fiio%2Fadc%2Faspeed_adc.txt&data=02%7C01%7Cc_mykolak%40mellanox.com%7Cbb1dcd32fbce4588d8cf08d4c55bf631%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636350446161614183&sdata=Xg4aMhMddCrvBd8S8au0DjWZrRsrgWQB2FO7O0xAKVw%3D&reserved=0">https://github.com/openbmc/linux/blob/dev-4.7/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt</a>.
<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On Fri, Jul 7, 2017 at 2:12 AM, Mykola Kostenok <<a href="mailto:c_mykolak@mellanox.com" target="_blank">c_mykolak@mellanox.com</a>> wrote:<o:p></o:p></p>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal" style="margin-bottom:12.0pt">Add adc for Mellanox msn platform to dts.<br>
<br>
Signed-off-by: Mykola Kostenok <<a href="mailto:c_mykolak@mellanox.com">c_mykolak@mellanox.com</a>><br>
---<br>
arch/arm/boot/dts/aspeed-bmc-mellanox-msn.dts | 45 +++++++++++++++++++++++++++<br>
1 file changed, 45 insertions(+)<br>
<br>
diff --git a/arch/arm/boot/dts/aspeed-bmc-mellanox-msn.dts b/arch/arm/boot/dts/aspeed-bmc-mellanox-msn.dts<br>
index 0774959b1222..462a638e66c6 100644<br>
--- a/arch/arm/boot/dts/aspeed-bmc-mellanox-msn.dts<br>
+++ b/arch/arm/boot/dts/aspeed-bmc-mellanox-msn.dts<br>
@@ -139,3 +139,48 @@<br>
status = "okay";<br>
};<br>
<br>
+&adc {<br>
+ status = "okay";<br>
+ #address-cells = <1>;<br>
+ #size-cells = <0>;<br>
+ adc1 {<br>
+ channel = <0>;<br>
+ min = <677>;<br>
+ max = <828>;<br>
+ };<br>
+ adc2 {<br>
+ channel = <2>;<br>
+ min = <684>;<br>
+ max = <836>;<br>
+ };<br>
+ adc3 {<br>
+ channel = <3>;<br>
+ min = <684>;<br>
+ max = <836>;<br>
+ };<br>
+ adc4 {<br>
+ channel = <4>;<br>
+ min = <676>;<br>
+ max = <826>;<br>
+ };<br>
+ adc5 {<br>
+ channel = <10>;<br>
+ min = <691>;<br>
+ max = <845>;<br>
+ };<br>
+ adc6 {<br>
+ channel = <11>;<br>
+ min = <640>;<br>
+ max = <782>;<br>
+ };<br>
+ adc7 {<br>
+ channel = <12>;<br>
+ min = <615>;<br>
+ max = <751>;<br>
+ };<br>
+ adc8 {<br>
+ channel = <13>;<br>
+ min = <587>;<br>
+ max = <719>;<br>
+ };<br>
+};<br>
<span class="hoenzb"><span style="color:#888888">--</span></span><span style="color:#888888"><br>
<span class="hoenzb">2.11.0</span></span><o:p></o:p></p>
</blockquote>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</div>
</body>
</html>