[PATCH linux dev-4.7 v2 3/7] drivers/fsi: Define hub master callbacks

Christopher Bostic cbostic at linux.vnet.ibm.com
Thu Feb 23 03:33:03 AEDT 2017



On 2/21/17 7:06 PM, Jeremy Kerr wrote:
> Hi Chris,
>
>> Define hub master read, write, link enable, and break ops.
> Now that we have things more contained, you may want to add the complete
> hub functionality in one patch.
Hi Jeremy,

OK will add all in one patch.

> However:
>
>> @@ -571,6 +598,7 @@ static int fsi_slave_init(struct fsi_master *master,
>>   	slave->id = slave_id;
>>   	slave->dev.parent = master->dev;
>>   	slave->dev.release = fsi_slave_release;
>> +	slave->link = link;
>>   
>>   	dev_set_name(&slave->dev, "slave@%02x:%02x", link, slave_id);
>>   	rc = device_register(&slave->dev);
> This looks like a generally-useful fix, for more than just the hub code.

This was uncovered in hub link testing.  Will treat it as a separate
patch from hub  and error handling.

Thanks


> Otherwise, looks good.
>
> Cheers,
>
>
> Jeremy
>



More information about the openbmc mailing list