[PATCH linux dev-4.7 v2 3/7] drivers/fsi: Define hub master callbacks
Jeremy Kerr
jk at ozlabs.org
Wed Feb 22 12:06:17 AEDT 2017
Hi Chris,
> Define hub master read, write, link enable, and break ops.
Now that we have things more contained, you may want to add the complete
hub functionality in one patch.
However:
> @@ -571,6 +598,7 @@ static int fsi_slave_init(struct fsi_master *master,
> slave->id = slave_id;
> slave->dev.parent = master->dev;
> slave->dev.release = fsi_slave_release;
> + slave->link = link;
>
> dev_set_name(&slave->dev, "slave@%02x:%02x", link, slave_id);
> rc = device_register(&slave->dev);
This looks like a generally-useful fix, for more than just the hub code.
Otherwise, looks good.
Cheers,
Jeremy
More information about the openbmc
mailing list