[PATCH linux dev-4.7 2/3] ARM: dts: aspeed: romulus: Add fsi-master GPIO bindings

[Mine]

Hi Andrew,

On Thu, Feb 16, 2017 at 9:21 AM, Andrew Jeffery <andrew at aj.id.au> wrote:
> Hi Lei,
>
> On Tue, 2017-02-14 at 15:30 +0800, Lei YU wrote:
>> Define the pins used on Romulus by the FSI GPIO master.
>>
>> > Signed-off-by: Lei YU <mine260309 at gmail.com>
>> ---
>>  arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 13 ++++++++++++-
>>  1 file changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
>> index f47eb63..bc13ad9 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
>> @@ -1,7 +1,7 @@
>>  /dts-v1/;
>>
>>  #include "aspeed-g5.dtsi"
>> -#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/gpio/aspeed-gpio.h>
>>
>>  / {
>> >     model = "Romulus BMC";
>> @@ -31,6 +31,17 @@
>> >             };
>> >     };
>>
>> > +   fsi-master {
>> > +           compatible = "ibm,fsi-master", "ibm,fsi-master-gpio";
>> +
>> > +           status = "disabled";
>> +
>> +             clock-gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_HIGH>;
>
> This looks okay
>
>> +             data-gpios = <&gpio ASPEED_GPIO(AA, 2) GPIO_ACTIVE_HIGH>;
>
> According to my Romulus datasheet, FSI_SOFT_DAT is GPIOE0 and GPIOAA2
> doesn't appear to be connected. Am I looking at an out-of-date
> datasheet? Did something change here?

Romulus FSI_SOFT_DAT is always GPIOAA2 (from GPIO Romulus 20161102.xls
to GPIO Romulus 20170112.xls, and I confirm that FSI is working with
this config.
Maybe you were referring Witherspoon's GPIO, where FSI_SOFT_DAT is GPIOE0?

>
>> +             mux-gpios = <&gpio ASPEED_GPIO(A, 6) GPIO_ACTIVE_HIGH>;
>> > +           enable-gpios = <&gpio ASPEED_GPIO(D, 0) GPIO_ACTIVE_HIGH>;
>> +             trans-gpios = <&gpio ASPEED_GPIO(R, 2) GPIO_ACTIVE_HIGH>;
>
> These three also look okay to me.
>
> Andrew
>
>> +     };
>>  };
>>
>>  &fmc {