[PATCH linux dev-4.7 2/3] ARM: dts: aspeed: romulus: Add fsi-master GPIO bindings

[Andrew Jeffery]

Hi Lei,

On Tue, 2017-02-14 at 15:30 +0800, Lei YU wrote:
> Define the pins used on Romulus by the FSI GPIO master.
> 
> > Signed-off-by: Lei YU <mine260309 at gmail.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> index f47eb63..bc13ad9 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> @@ -1,7 +1,7 @@
>  /dts-v1/;
>  
>  #include "aspeed-g5.dtsi"
> -#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/gpio/aspeed-gpio.h>
>  
>  / {
> >  	model = "Romulus BMC";
> @@ -31,6 +31,17 @@
> >  		};
> >  	};
>  
> > +	fsi-master {
> > +		compatible = "ibm,fsi-master", "ibm,fsi-master-gpio";
> +
> > +		status = "disabled";
> +
> +		clock-gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_HIGH>;

This looks okay

> +		data-gpios = <&gpio ASPEED_GPIO(AA, 2) GPIO_ACTIVE_HIGH>;

According to my Romulus datasheet, FSI_SOFT_DAT is GPIOE0 and GPIOAA2
doesn't appear to be connected. Am I looking at an out-of-date
datasheet? Did something change here?

> +		mux-gpios = <&gpio ASPEED_GPIO(A, 6) GPIO_ACTIVE_HIGH>;
> > +		enable-gpios = <&gpio ASPEED_GPIO(D, 0) GPIO_ACTIVE_HIGH>;
> +		trans-gpios = <&gpio ASPEED_GPIO(R, 2) GPIO_ACTIVE_HIGH>;

These three also look okay to me.

Andrew

> +	};
>  };
>  
>  &fmc {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20170216/58961e31/attachment.sig>