[PATCH] Initial driver for the MAX31785 intelligent fan controller

[Joel Stanley]

Hello Timothy,

On Tue, Sep 20, 2016 at 11:22 AM, Timothy Pearson
<tpearson at raptorengineering.com> wrote:
> Add a basic driver for the MAX31785, focusing on the fan control
> features but ignoring the temperature and voltage monitoring
> features of the device.
>
> This driver supports all fan control modes and tachometer / PWM
> readback where applicable.

> This series adds a new hwmon driver for the MAX31875, which is
> used for fan control on Firestone.
>
> This patch is a holdover until a PMBus driver is written at some
> point.  Upstream has stated they will not accept unless a PMBus
> driver is used for this particular device.

I'm happy to carry this in our tree for now.

Do you have a timeline for rewriting and submitting upstream?

>
> Signed-off-by: Timothy Pearson <tpearson at raptorengineering.com>
> ---
>  Documentation/hwmon/max31785 |   36 +++
>  MAINTAINERS                  |    7 +

The change to maintianers should be in a separate patch.

>  drivers/hwmon/Kconfig        |   10 +
>  drivers/hwmon/Makefile       |    1 +
>  drivers/hwmon/max31785.c     |  714 ++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 768 insertions(+)
>  create mode 100644 Documentation/hwmon/max31785
>  create mode 100644 drivers/hwmon/max31785.c
>

> +
> +static const struct i2c_device_id max31785_id[] = {
> +       { "max31785", 0 },
> +       { }
> +};
> +MODULE_DEVICE_TABLE(i2c, max31785_id);

No device tree bindings?

> +
> +static struct i2c_driver max31785_driver = {
> +       .class          = I2C_CLASS_HWMON,
> +       .probe          = max31785_probe,
> +       .driver = {
> +               .name   = "max31785",
> +       },
> +       .id_table       = max31785_id,
> +       .detect         = max31785_detect,
> +       .address_list   = normal_i2c,
> +};
> +
> +module_i2c_driver(max31785_driver);
> +
> +MODULE_AUTHOR("Timothy Pearson <tpearson at raptorengineering.com>");
> +MODULE_DESCRIPTION("MAX31785 sensor driver");
> +MODULE_LICENSE("GPL");
> --
> 1.7.9.5
>
> _______________________________________________
> openbmc mailing list
> openbmc at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc