[PATCH linux v5 0/7] Introducing the FSI device driver

Christopher Bostic christopher.lee.bostic at gmail.com
Thu Sep 22 04:49:43 AEST 2016


On Wed, Sep 7, 2016 at 7:10 PM, Joel Stanley <joel at jms.id.au> wrote:
> Hi Chris,
>
> On Fri, Sep 2, 2016 at 2:35 PM, Joel Stanley <joel at jms.id.au> wrote:
>> Hi Chris,
>>
>> On Thu, Aug 25, 2016 at 5:24 AM,  <christopher.lee.bostic at gmail.com> wrote:
>>> From: Chris Bostic <cbostic at us.ibm.com>
>>>
>>> Introduction of the IBM 'Flexible Support Interface' (FSI) bus device
>>> driver. FSI is a high fan out serial bus consisting of a clock and a serial
>>> data line capable of running at speeds up to 166 MHz.
>>
>
> I've taken a look at the patches. There doesn't seem to be much
> improvement over the last version.

Not sure I follow what you mean by improvement.  There is more
function added with this last set.  In terms of incorporating Jeremy's
changes I will attempt to follow his suggestions but I'm a little
unclear if you are expecting those to be done verbatim as per his
example.   The patches are rather small and so to incorporate ~ 5
KLOCs would require an enormous patch set or series of sets.

I've been working on the next set and will get that to you soon.  I
don't, however, want to send another set without much improvement so
let me know how I can do this.

>
>> I was wondering if you have had a look at Jeremy's implementation yet?
>> If so, are there any ideas you have incorporated into your series?
>
> I recommend you consider these questions and get back to me.
>
> Cheers,
>
> Joel


More information about the openbmc mailing list