[PATCH 03/19] Ensure that the old style MDIO interface is active

Timothy Pearson tpearson at raptorengineering.com
Tue Sep 20 11:47:31 AEST 2016


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/19/2016 07:29 PM, Andrew Jeffery wrote:
> I've had a look at this patch from your git repo on github. Whilst git-
> send-email is changing the patch in ways you're not expecting, it's
> because your commit message isn't formatted in the manner expected by
> git's tools. Your object looks like:
> 
>     ftgmac100: Enable old-style MDIO interface
> 

Good catch.  Today was fairly hectic on this end and I had a grand total
of a couple of minutes to look into the problem. :-)

> Separately, I had some questions on the v1 of the patch. Can you
> pleaserespond to those?

Sure!  From a high level, this driver does not support anything other
than the old-style MDIO interface.  The hardware sets the new-style bit
when support is available, so the driver itself should be able to
determine which style of interface to use at runtime (in theory).

> Hope that helps,
> 
> Andrew



- -- 
Timothy Pearson
Raptor Engineering
+1 (415) 727-8645 (direct line)
+1 (512) 690-0200 (switchboard)
https://www.raptorengineering.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJX4JUzAAoJEK+E3vEXDOFbmKoH/Ay2cGaQ4U9VlayODUiqUrcY
RAyG6iC1iHFxooPKKWqZiNMPcbey+Of1Eq+t2jKn0P5RDRo/8nwXiakJrkr+NmJc
j+nM96i9eTbg4bA3cdk7aGaVd7jjmAeoqK3Fz64ansYYD55rlynfrCZli1zYZgkC
3rf22JP6A6H/ibshLHjjawZF5mU9p+ngv0iYMyryK5sBzXWGXrZAfc7xmBR9fXpA
yZbhFzwL4CnbLSclWvx/wMoTMejrDe3V4n/7XGrNZFspt6jt1WkjrmMIDQcJUPnq
PYqZmBowsi9EsAMufUKhZ4WQcHfJKMMFG90m3PXdkJyD85qX3c5PvJ77aZYa4sQ=
=vN3E
-----END PGP SIGNATURE-----


More information about the openbmc mailing list