[PATCH 06/16] mach-aspeed: Add missing Firestone setup method and

Timothy Pearson tpearson at raptorengineering.com
Sat Sep 17 00:14:10 AEST 2016

Hash: SHA1

On 09/15/2016 08:22 PM, Andrew Jeffery wrote:
> Can you please document exactly what this is (de)configuring and why?
> That way when we come to remove the hack we have some context.
> Better yet, according to `bitfield`:
> $ bitfield SCU88 0xD7000000
> decoding as SCU Multi-function Pin Control #3
> 0xd7000000 [3607101440]
>                                     Enable MAC#1 MDIO1: 0x1
>                                      Enable MAC#1 MDC1: 0x1
>                                Enable NOR flash ROMA25: 0x0
>                                Enable NOR flash ROMA24: 0x1
>                                   Enable flash ROMCS4#: 0x0
>                                   Enable flash ROMCS3#: 0x1
>                                   Enable flash ROMCS2#: 0x1
>                                   Enable flash ROMCS1#: 0x1
>                                   ...
> And as such each of these can be configured through the devicetree via
> pinmux functions MDIO1, ROM16, ROMCS[321]. However, looking at the
> pinmux driver, whilst ROMCS[321] are defined for the relevant pins they
> don't look to have been added to the list of exported functions in dev-
> 4.7. I'll have to dig further into that, but it's probably an oversight
> on my part.
> Out of interest, what are you doing with ROMA24? Is that actually
> required, and if so, is it meant to be independent of ROMA25? I may
> have to rethink my approach there.

No, it's not required, at least on Firestone.  In fact none of the
ROMAnn pins are required; the entire NOR interface is either used for
pin straps or is disconnected.

I'm going to say this was bad copypasta from the other _setup functions
and delete the line entirely.  I'll re-submit this patch shortly.

- -- 
Timothy Pearson
Raptor Engineering
+1 (415) 727-8645 (direct line)
+1 (512) 690-0200 (switchboard)
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/


More information about the openbmc mailing list