[linux dev-4.7 2/3] arm: dts: aspeed: Add spi1 pins to g5 device tree

Andrew Jeffery andrew at aj.id.au
Fri Sep 16 10:31:14 AEST 2016


On Thu, 2016-09-15 at 20:43 +0930, Joel Stanley wrote:
> Signed-off-by: Joel Stanley <joel at jms.id.au>
> ---
>  arch/arm/boot/dts/aspeed-g5.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index f73a2b18e152..e4e43ae3616a 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -201,6 +201,17 @@
>  						function = "RMII2";
>  						groups = "RMII2";
>  					};
> +
> +					pinctrl_spi1_master_default: spi1_master_default {
> +						function = "SPI1_MASTER";
> +						groups = "SPI1_MASTER";
> +					};
> +
> +					pinctrl_spi1_passthru_default: spi1_passthru_default {
> +						function = "SPI1_PASSTHRU";
> +						groups = "SPI1_PASSTHRU";
> +					};
> +

This looks fine, however I think we should add VGABIOS_ROM and SYSSPI
given you went to the effort of defining them in the driver.

Cheers,

Andrew

>  				};
>  			};
>  
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20160916/7e580050/attachment-0001.sig>


More information about the openbmc mailing list