[RFC PATCH linux dev-4.7 4/6] misc: Add Aspeed BT IPMI BMC driver

Cédric Le Goater clg at kaod.org
Thu Sep 15 17:37:22 AEST 2016


On 09/15/2016 09:09 AM, Joel Stanley wrote:
> On Thu, Sep 15, 2016 at 4:02 PM, Cédric Le Goater <clg at kaod.org> wrote:
>> From: Alistair Popple <alistair at popple.id.au>
>>
>> This patch adds a simple device driver to expose the iBT interface on
>> Aspeed SOCs (AST2400 and AST2500) as a character device :
>> /dev/ipmi-bt-bmc.
>>
>> The BT (Block Transfer) interface is used to perform in-band IPMI
>> communication from a BMC to the host. Entire messages are buffered
>> before sending a notification to the host, or the BMC when on the
>> other side, that there is data to be read. The driver implements the
>> BMC side of the BT interface.
>>
>> Signed-off-by: Alistair Popple <alistair at popple.id.au>
>> Signed-off-by: Jeremy Kerr <jk at ozlabs.org>
>> Signed-off-by: Joel Stanley <joel at jms.id.au>
>> [clg: - did some checkpatch fixes
>>       - added a devicetree binding documentation
>>       - renamed 'bt_host' to 'bt_bmc' to reflect that the driver is
>>         the BMC side of the IPMI BT interface
>>       - remaned the device name to 'ipmi-bt-bmc'
> 
> I'm not sure there. When I open /dev/ttyUSB0 I'm talking to the USB0
> serial device. When I open /dev/mtd0, I'm talking to the mtd0 device.
> So when I open /dev/ipmi-bt-bmc, I would expect to talk to the BMC
> device?

Yes. I went a little too far in the global rename. /dev/ipmi-bt-bmc makes 
more sense or just '/dev/ipmi-bt' because we won't have multiple hosts
to control.

C.



More information about the openbmc mailing list