Celebration in the streets (aka pinmux is merged)
joel at jms.id.au
Thu Sep 8 15:24:46 AEST 2016
Congratulations Andrew and everyone who has helped with design,
testing and review.
This is a major component of the Aspeed SoC support that is now
complete. It allows us to configure the pads (pins) of the SoC using
the device tree and/or from other drivers, instead of looking up
registers in the datasheet and sticking values all over the place.
The driver is in the subsystem tree and on it's way to appear in Linux 4.9.
---------- Forwarded message ----------
From: Linus Walleij <linus.walleij at linaro.org>
Date: Thu, Sep 8, 2016 at 12:20 AM
Subject: Re: [PATCH v3 5/8] pinctrl: Add core support for Aspeed SoCs
To: Andrew Jeffery <andrew at aj.id.au>
Cc: Joel Stanley <joel at jms.id.au>, Alexandre Courbot
<gnurou at gmail.com>, Mark Rutland <mark.rutland at arm.com>, Rob Herring
<robh+dt at kernel.org>, Benjamin Herrenschmidt
<benh at kernel.crashing.org>, Jeremy Kerr <jk at ozlabs.org>,
"linux-gpio at vger.kernel.org" <linux-gpio at vger.kernel.org>,
"linux-kernel at vger.kernel.org" <linux-kernel at vger.kernel.org>,
"devicetree at vger.kernel.org" <devicetree at vger.kernel.org>
On Tue, Aug 30, 2016 at 9:54 AM, Andrew Jeffery <andrew at aj.id.au> wrote:
> The Aspeed SoCs typically provide more than 200 pins for GPIO and other
> functions. The signal enabled on a pin is determined on a priority
> basis, where a given pin can provide a number of different signal types.
> In addition to the priority levels, the Aspeed pin controllers describe
> the signal active on a pin by compound logical expressions involving
> multiple operators, registers and bits. Some difficulty arises as a
> pin's function bit masks for each priority level are frequently not the
> same (i.e. we cannot just flip a bit to change from a high to low
> priority signal), or even in the same register(s). Some configuration
> bits affect multiple pins, while in other cases the signals for a bus
> must each be enabled individually.
> Together, these features give rise to some complexity in the
> implementation. A more complete description of the complexities is
> provided in the associated header file.
> The patch doesn't implement pinctrl/pinmux/pinconf for any particular
> Aspeed SoC, rather it adds the framework for defining pinmux
> Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> Reviewed-by: Joel Stanley <joel at jms.id.au>
Patch applied! It's not getting better than this through iteration, it is better
to get the system up and develop inside the mainline tree from now on.
More information about the openbmc