[PATCH u-boot v2 4/6] aspeed: Add function to calculate APB Clock frequency

Simon Glass sjg at chromium.org
Mon Nov 28 04:02:04 AEDT 2016


On 23 November 2016 at 17:28, Maxim Sloyko <maxims at google.com> wrote:
> This is needed by I2C driver.
>
> Signed-off-by: Maxim Sloyko <maxims at google.com>
> ---
> Changes for v1:
>         Add function comment.
> ---
>  arch/arm/include/asm/arch-aspeed/ast_scu.h |  4 ++++
>  arch/arm/mach-aspeed/ast-scu.c             | 13 +++++++++++++
>  2 files changed, 17 insertions(+)

Reviewed-by: Simon Glass <sjg at chromium.org>

(for mainline you would want to add @param and @return to your
function comment. See other exampes...

- Simon


More information about the openbmc mailing list