[RFC PATCH linux 0/9] On-Chip Controller (OCC) hwmon driver

[Joel Stanley]

On 11 Nov 2016 14:43, "Andrew Jeffery" <andrew at aj.id.au> wrote:
> So I have reworked them into what is now 8 patches (see below) and tried
to
> tell a bit more of a story with them (hopefully I succeeded!) Second, I
tried
> my hand at reworking the layering as mentioned above, such that hardware
> interaction is split from sysfs, and that the SCOM transport and sensor
> configuration is decoupled from the data parsing. You largely had all of
these
> in-place already, I just cut and pasted code around a bit.

Did you look at Jeremy and Chris B's FSI patches? I think you would be the
first client of their new interfaces.

> Please review the patches and provide feedback! I'd like to hear
arguments for
> or against both of our approaches. Note though that I've only tested that
these
> patches compile, I absolutely have not done any further testing.
>
> Joel: Any chance you could chime in with an architectural review?

No worries.

> When the dust has settled on the bigger issues we can start to look at the
> finer details of the APIs (there are some bugs, oddities and complexities
that
> I would like to address before they are applied to openbmc/linux).

I suggest the next step is upstream review. We can put them in the tree if
it's urgent, but I trust that you and Eddie will beat them into shape in no
time. If you succeed we can then apply the upstream versions directly.

Cheers,

Joel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20161111/fffb4757/attachment.html>