[PATCH linux] ARM: dts: aspeed-g5: Update zaius with new spi-nor binding

[Xo Wang]

Hi Joel, Andrew,

On Tue, Nov 1, 2016 at 4:58 PM, Andrew Jeffery <andrew at aj.id.au> wrote:
> On Wed, 2016-11-02 at 10:15 +1030, Joel Stanley wrote:
>> Hey Xo,
>>
>> On Wed, Nov 2, 2016 at 10:00 AM, Xo Wang <xow at google.com> wrote:
>>
>> >
>> > +&spi1 {
>> > +       status = "okay";
>> > +       pinctrl-names = "default";
>> > +       pinctrl-0 = <&pinctrl_spi1_default>;
>> > +
>> > +       flash at 0 {
>> > +               status = "okay";
>> > +               label = "pnor";
>> > +       };
>> > +};
>> > +
>> > +&spi2 {
>> > +       status = "okay";
>> I think we want to request the pins here. Something like this:
>>
>> +
>> +         pinctrl-names = "default";
>> +         pinctrl-0 = <&pinctrl_spi2ck_default
>> +                         &pinctrl_spi2cs0_default
>> +                         &pinctrl_spi2cs1_default
>> +                         &pinctrl_spi2miso_default
>> +                         &pinctrl_spi2mosi_default>;
>
> Yes, we need this, though maybe the chip selects should be pushed out
> to the board dts?
>
> Andrew
>
>> +
>>
>> Can you try that and do a test boot on your hardware?

Good catch! I hadn't picked up that the SPI2 flash wasn't being
probed. Now it's showing up:

platform 1e620000.flash-controller:flash at 0: mx66l51235l (65536 Kbytes)
6 ofpart partitions found on MTD device bmc
Creating 6 MTD partitions on "bmc":
0x000000000000-0x000000060000 : "u-boot"
0x000000060000-0x000000080000 : "u-boot-env"
0x000000080000-0x000000300000 : "kernel"
0x000000300000-0x0000004c0000 : "initramfs"
0x0000004c0000-0x000001c00000 : "rofs"
0x000001c00000-0x000002000000 : "rwfs"
aspeed-smc 1e630000.flash-controller: no DMA support.
platform 1e630000.flash-controller:flash at 0: mx66l51235l (65536 Kbytes)
aspeed-smc 1e631000.flash-controller: no DMA support.
platform 1e631000.flash-controller:flash at 0: mx25l6405d (8192 Kbytes)

cheers
xo

>>
>> Cheers,
>>
>> Joel
>>
>> >
>> > +       flash at 0 {
>> > +               status = "okay";
>> > +       };
>> > +};
>> > +