[PATCH linux] ARM: dts: aspeed-g5: Update zaius with new spi-nor binding
Andrew Jeffery
andrew at aj.id.au
Wed Nov 2 10:58:52 AEDT 2016
On Wed, 2016-11-02 at 10:15 +1030, Joel Stanley wrote:
> Hey Xo,
>
> On Wed, Nov 2, 2016 at 10:00 AM, Xo Wang <xow at google.com> wrote:
>
> >
> > +&spi1 {
> > + status = "okay";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_spi1_default>;
> > +
> > + flash at 0 {
> > + status = "okay";
> > + label = "pnor";
> > + };
> > +};
> > +
> > +&spi2 {
> > + status = "okay";
> I think we want to request the pins here. Something like this:
>
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_spi2ck_default
> + &pinctrl_spi2cs0_default
> + &pinctrl_spi2cs1_default
> + &pinctrl_spi2miso_default
> + &pinctrl_spi2mosi_default>;
Yes, we need this, though maybe the chip selects should be pushed out
to the board dts?
Andrew
> +
>
> Can you try that and do a test boot on your hardware?
>
> Cheers,
>
> Joel
>
> >
> > + flash at 0 {
> > + status = "okay";
> > + };
> > +};
> > +
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20161102/badf6c2b/attachment-0001.sig>
More information about the openbmc
mailing list