[PATCH openbmc v2] Re-enable out of tree device trees

Joel Stanley joel at jms.id.au
Thu May 19 11:56:01 AEST 2016


Hi Brad,

On Wed, May 18, 2016 at 12:00 AM, OpenBMC Patches
<openbmc-patches at stwcx.xyz> wrote:
> From: Brad Bishop <bradleyb at fuzziesquirrel.com>
>
> This snippet was mistakenly removed with 8ef9fee.

It was intentionally removed.

> Note that this isn't a matter of policy, it simply enables
> the option to do it.  The in-tree device tree is still the default.
>
> This enables things like workbook or schematic generated device
> trees.  It also addresses the inevitable fact that the upstream kernel
> will probably not want device trees for every board in the world.

As we do development the device tree is strongly coupled to the
kernel. I think we want to keep the dts in the kernel tree, so that
changes are made together.

Secondly, when testing kernels the developer may or may not be using
the poky environment. This means that the developer writing and
supporting your kernel is not testing the same code that is running on
the board.

We can add every device trees to our kernel tree. As the upstream
maintainer of the aspeed port, I will also send them all upstream.

Cheers,

Joel

>
> Signed-off-by: Brad Bishop <bradleyb at fuzziesquirrel.com>
> ---
>  meta-phosphor/common/recipes-kernel/linux/linux-obmc_4.4.bb | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/meta-phosphor/common/recipes-kernel/linux/linux-obmc_4.4.bb b/meta-phosphor/common/recipes-kernel/linux/linux-obmc_4.4.bb
> index 24cde9f..945b43d 100644
> --- a/meta-phosphor/common/recipes-kernel/linux/linux-obmc_4.4.bb
> +++ b/meta-phosphor/common/recipes-kernel/linux/linux-obmc_4.4.bb
> @@ -18,3 +18,13 @@ COMPATIBLE_MACHINE_${MACHINE} = "openbmc"
>
>  inherit kernel
>  require recipes-kernel/linux/linux-yocto.inc
> +
> +do_patch_append() {
> +        for DTB in "${KERNEL_DEVICETREE}"; do
> +               DT=`basename ${DTB} .dtb`
> +                if [ -r "${WORKDIR}/${DT}.dts" ]; then
> +                        cp ${WORKDIR}/${DT}.dts \
> +                                ${STAGING_KERNEL_DIR}/arch/${ARCH}/boot/dts
> +               fi
> +       done
> +}
> --
> 2.8.2
>
>
> _______________________________________________
> openbmc mailing list
> openbmc at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc


More information about the openbmc mailing list