[RFC PATCH openbmc v3 1/8] meta-openbmc-bsp: Add qemu git recipe

[Andrew Jeffery]

Hi Patrick,

Thanks for the feedback.

On Mon, 2016-05-16 at 15:14 -0500, Patrick Williams wrote:
> On Wed, Mar 23, 2016 at 06:33:28PM +1030, Andrew Jeffery wrote:
> ...
> > 
> > Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> > ---
> >  meta-openbmc-bsp/conf/layer.conf                   |   8 ++
> > 
> >  .../recipes-devtools/qemu/qemu-targets.inc         |  22 ++++
> >  meta-openbmc-bsp/recipes-devtools/qemu/qemu.inc    | 125 +++++++++++++++++++++
> These files are originally in meta/recipes-devtools/qemu.  We should
> be able to continue to use those.

As pointed out in my comment on the pull-req[1] qemu.inc isn't a bit-
for-bit copy, I've changed (removed) some parts. However it's likely
there is a better approach than deleting parts of the configuration.

qemu-targets.inc was a straight copy, but I don't know of a way to
reference it from the new qemu recipe. Removing it doesn't make the new
recipe find it in the old recipe's directory...

> 
> > 
> >  meta-openbmc-bsp/recipes-devtools/qemu/qemu_git.bb |  21 ++++
> I would prefer this under
> meta-openbmc-bsp/meta-aspeed/meta-ast2400/recipes-bsp , since it is the
> 2400 specific qemu tree.
> 
> I think you can avoid the layer.conf and bblayers.conf changes if you
> use the (already supported) meta-ast2400 tree as well.

Yeah, happy to do that. I asked where people prefer I put it (can't
remember where I asked though) and got no feedback, so for the patch I
put it here on the basis that if people disagreed they'd have an
opinion :)

> 
> > 
> >  .../meta-palmetto/conf/bblayers.conf.sample        |   1 +
> >  .../meta-barreleye/conf/bblayers.conf.sample       |   1 +
> > 
> > diff --git a/meta-openbmc-bsp/conf/layer.conf b/meta-openbmc-bsp/conf/layer.conf
> > new file mode 100644
> > index 0000000..7f07802
> > --- /dev/null
> > +++ b/meta-openbmc-bsp/conf/layer.conf
> > @@ -0,0 +1,8 @@
> > +# We have a conf and classes directory, add to BBPATH
> > +BBPATH .= ":${LAYERDIR}"
> > +# We have a recipes directory containing .bb and .bbappend files, add to BBFILES
> > +BBFILES := "${BBFILES} ${LAYERDIR}/recipes*/*/*.bb \ ${LAYERDIR}/recipes*/*/*.bbappend"
> > +
> > +BBFILE_COLLECTIONS += "openbmc-bsp"
> > +BBFILE_PATTERN_openbmc-bsp = ""
> > +BBFILE_PRIORITY = "1"
> I think we can remove this by moving to meta-ast2400.  Not sure I
> understand why this was required.

Yeah it's likely we can remove it. It was an experiment that I don't
think is required and shouldn't have made it into the pull-req.

> 
> > 
> > diff --git a/meta-openbmc-bsp/recipes-devtools/qemu/qemu_git.bb b/meta-openbmc-bsp/recipes-devtools/qemu/qemu_git.bb
> > new file mode 100644
> > index 0000000..97667ba
> > --- /dev/null
> > +++ b/meta-openbmc-bsp/recipes-devtools/qemu/qemu_git.bb
> > @@ -0,0 +1,21 @@
> > +# Based off of [1], appears to be MIT licensed [2].
> > +#
> > +# [1] https://github.com/dirtybit/gumstix-yocto/blob/master/meta/recipes-devtools/qemu/qemu_git.bb
> > +# [2] https://github.com/dirtybit/gumstix-yocto/blob/master/meta/COPYING.MIT
> I don't think you need to say this.  This doesn't look that much
> different from qemu_2.4.0.bb except for the SRCREV / SRC_URI / S
> variables and those are really standard with other of our recipes.
> 

Yeah I'll strip it out. Initially it looked more like the linked
content, but I stripped it back as I went.

> > 
> > +
> > +require qemu.inc
> > +
> > +SRCREV = "d1f8764099022bc1173f2413331b26d4ff609a0c"
> > +
> > +LIC_FILES_CHKSUM = "file://COPYING;md5=441c28d2cf86e15a37fa47e15a72fbac \
> > +                    file://COPYING.LIB;endline=24;md5=c04def7ae38850e7d3ef548588159913"
> > +
> > +SRC_URI = "git://github.com/openbmc/qemu.git;protocol=https"
> > +S = "${WORKDIR}/git"
> > +
> > +COMPATIBLE_HOST_class-target_mips64 = "null"
> > +
> > +do_install_append() {
> > +    # Prevent QA warnings about installed ${localstatedir}/run
> > +    if [ -d ${D}${localstatedir}/run ]; then rmdir ${D}${localstatedir}/run; fi
> > +}

[1] https://github.com/openbmc/openbmc/pull/230#issuecomment-212228955
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20160517/32281f0b/attachment.sig>