[PATCH ipmi-fru-parser] Increase size of buffer length variable

Stewart Smith stewart at linux.vnet.ibm.com
Mon May 16 10:53:15 AEST 2016


Adriana Kobylak <anoo at us.ibm.com> writes:
> The size of size_t is different in 32 and 64-bit architectures. There has 
> been issues in the past in op-build where we had to change size_t to 
> uint32_t to support compiling in 64-bit. So thought I'd make the change 
> consistent and change the length to uint32_t.

If size_t is part of a binary format, then yes, this matters.

Otherwise, it really shouldn't - addressing things >2GB on 32bit systems
is going to be problematic anyway, and all that really should matter
there is off_t vs off64_t if you're doing seeking in large files.


So what exactly is the problem with size_t here?

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the openbmc mailing list