[PATCH phosphor-host-ipmid] Fixing the Duplicate registration for NetFn [0x6], Cmd:[0xFF]
Chris Austen
austenc at us.ibm.com
Fri Feb 26 22:42:40 AEDT 2016
Removal looks good.
The wildcard function exists in each of the ipmi .so files. To remove them would be a decision to be discussed beyond the scope of this piece of work.
Signed off by Chris austen. <austenc at us.ibm.com>
Sent from my iPhone using IBM Verse
On Feb 25, 2016, 11:48:22 PM, cyrilbur at gmail.com wrote:
From: cyrilbur at gmail.com
To: openbmc-patches at stwcx.xyz
Cc: ratagupt at in.ibm.com, openbmc at lists.ozlabs.org
Date: Feb 25, 2016 11:48:22 PM
Subject: Re: [PATCH phosphor-host-ipmid] Fixing the Duplicate registration for NetFn [0x6], Cmd:[0xFF]
On Thu, 25 Feb 2016 07:40:36 -0600
OpenBMC Patches wrote:
> From: Ratan Gupta
>
Hi Ratan,
Any reason you're not removing ipmi_global_wildcard_handler() as well. I assume
it's now unused...
Thanks,
Cyril
> ---
> globalhandler.C | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/globalhandler.C b/globalhandler.C
> index e68ea79..25ae26a 100644
> --- a/globalhandler.C
> +++ b/globalhandler.C
> @@ -164,8 +164,5 @@ void register_netfn_global_functions()
> printf("Registering NetFn:[0x%X], Cmd:[0x%X]\n",NETFUN_APP, IPMI_CMD_WARM_RESET);
> ipmi_register_callback(NETFUN_APP, IPMI_CMD_WARM_RESET, NULL, ipmi_global_warm_reset);
>
> - printf("Registering NetFn:[0x%X], Cmd:[0x%X]\n",NETFUN_APP, IPMI_CMD_WILDCARD);
> - ipmi_register_callback(NETFUN_APP, IPMI_CMD_WILDCARD, NULL, ipmi_global_wildcard_handler);
> -
> - return;
> + return;
> }
_______________________________________________
openbmc mailing list
openbmc at lists.ozlabs.org
https://lists.ozlabs.org/listinfo/openbmc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20160226/6473054c/attachment-0001.html>
More information about the openbmc
mailing list