<html><head><META http-equiv="Content-Type" content="text/html;charset=utf-8"></head><body><div id="content" contenteditable="true" spellcheck="true" autocorrect="true" autocapitalize="true" style="font-family: Helvetica;">Removal looks good. <div><br></div><div>The wildcard function exists in each of the ipmi .so files. To remove them would be a decision to be discussed beyond the scope of this piece of work. </div><div><br></div><div>Signed off by Chris austen. <austenc@us.ibm.com></div><div><br>Sent from my iPhone using IBM Verse<br><br><hr>On Feb 25, 2016, 11:48:22 PM, cyrilbur@gmail.com wrote:<br><br>From: cyrilbur@gmail.com<br>To: openbmc-patches@stwcx.xyz<br>Cc: ratagupt@in.ibm.com, openbmc@lists.ozlabs.org<br>Date: Feb 25, 2016 11:48:22 PM<br>Subject: Re: [PATCH phosphor-host-ipmid] Fixing the Duplicate registration for NetFn [0x6], Cmd:[0xFF]<br><br><div id="MaaS360PIMSDKOriginalMessageId">On Thu, 25 Feb 2016 07:40:36 -0600<br>OpenBMC Patches <openbmc-patches@stwcx.xyz> wrote:<br>> From: Ratan Gupta <ratagupt@in.ibm.com><br>> <br>Hi Ratan,<br>Any reason you're not removing ipmi_global_wildcard_handler() as well. I assume<br>it's now unused...<br>Thanks,<br>Cyril<br>> ---<br>> globalhandler.C | 5 +----<br>> 1 file changed, 1 insertion(+), 4 deletions(-)<br>> <br>> diff --git a/globalhandler.C b/globalhandler.C<br>> index e68ea79..25ae26a 100644<br>> --- a/globalhandler.C<br>> +++ b/globalhandler.C<br>> @@ -164,8 +164,5 @@ void register_netfn_global_functions()<br>> printf("Registering NetFn:[0x%X], Cmd:[0x%X]\n",NETFUN_APP, IPMI_CMD_WARM_RESET);<br>> ipmi_register_callback(NETFUN_APP, IPMI_CMD_WARM_RESET, NULL, ipmi_global_warm_reset);<br>> <br>> - printf("Registering NetFn:[0x%X], Cmd:[0x%X]\n",NETFUN_APP, IPMI_CMD_WILDCARD);<br>> - ipmi_register_callback(NETFUN_APP, IPMI_CMD_WILDCARD, NULL, ipmi_global_wildcard_handler);<br>> -<br>> - return;<br>> + return;<br>> }<br>_______________________________________________<br>openbmc mailing list<br>openbmc@lists.ozlabs.org<br>https://lists.ozlabs.org/listinfo/openbmc<br></ratagupt@in.ibm.com></openbmc-patches@stwcx.xyz></div></div></div><BR>
</body></html>