[PATCH linux v5 0/4] Seven segment display support

[Jaghathiswari Rankappagounder Natarajan]

Ok. I will send this driver upstream. Thanks for the feedback.
I haven't looked into the proposed lpc driver. I will look at that.

On Mon, Dec 12, 2016 at 4:31 PM, Joel Stanley <joel at jms.id.au> wrote:

> Hi Jagha,
>
> On Tue, Dec 13, 2016 at 10:58 AM, Jaghathiswari Rankappagounder
> Natarajan <jaghu at google.com> wrote:
> > Hi Joel,
> > Could you please help review this patch series. Would like to have the
> seven
> > segment display driver for testing out on zaius machine.
>
> I have spent a fair amount of time reading your code. It would be nice
> to see other developers take a look as well. Have you asked for review
> from your peers?
>
> > (I am trying to get the fan tach driver to work and I hope to send that
> a> along with pwm driver for review soon.)
>
> If you think this driver is ready to go, I suggest you send it
> upstream for wider community review. Same for the pwm driver. Make
> sure you cc me so I can help out.
>
> > Also you had mentioned about writing the LPC driver. Is that checked in?
>
> Andrew sent a proposed driver some time ago. Did you have time to review
> it?
>
>  http://patchwork.ozlabs.org/patch/693032/
>
> I think we may prefer an ioctl based approach, but this is up for debate.
>
> Cheers,
>
> Joel
>
> >
> > Thanks,
> > Jagha
> >
> > On Tue, Nov 22, 2016 at 6:45 PM, Joel Stanley <joel at jms.id.au> wrote:
> >>
> >> We spoke on IRC about the clock changes. Lets wait until those issues
> >> are addressed before reviewing this series.
> >>
> >> Cheers,
> >>
> >> Joel
> >>
> >> On Sun, Nov 20, 2016 at 5:57 PM, Jaghathiswari Rankappagounder
> >> Natarajan <jaghu at google.com> wrote:
> >> > This patchset includes:
> >> >
> >> > Documentation for the binding which provides an interface for adding
> >> > clock,
> >> > data and clear signal GPIO lines to control seven segment display.
> >> >
> >> > The platform device driver provides an API for displaying on two
> >> > 7-segment
> >> > displays, and implements the required bit-banging. The hardware
> assumed
> >> > is
> >> > 74HC164 wired to two 7-segment displays.
> >> >
> >> > The character device driver implements the user-space API for letting
> a
> >> > user
> >> > write to two 7-segment displays including any conversion methods
> >> > necessary
> >> > to map the user input to two 7-segment displays.
> >> >
> >> > Adding clock, data and clear signal GPIO lines in the devicetree to
> >> > control
> >> > seven segment display on zaius platform.
> >> >
> >> > The platform driver matches on the device tree node; the platform
> driver
> >> > also
> >> > initializes the character device.
> >> >
> >> > Tested that the seven segment display works properly by writing to the
> >> > character device file on EVB AST2500 board and on Zaius board.
> >> >
> >> > A changelog between versions is included in the individual patches.
> >> > Please
> >> > provide feedback.
> >> >
> >> > Jaghathiswari Rankappagounder Natarajan (4):
> >> >   Documentation: dt-bindings: Document bindings for seven segment
> >> >     display support
> >> >   drivers: misc: Character device driver for seven segment display
> >> >   drivers: misc: Platform driver for seven segment display support
> >> >   arm: dts: Add dt-binding to support seven segment display on zaius
> >> >
> >> >  .../devicetree/bindings/misc/seven-seg-gpio.txt    |  27 +++
> >> >  arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts         |   8 +
> >> >  drivers/misc/Kconfig                               |  16 ++
> >> >  drivers/misc/Makefile                              |   2 +
> >> >  drivers/misc/seven_seg_disp.c                      | 197
> >> > ++++++++++++++++++++
> >> >  drivers/misc/seven_seg_disp.h                      |  34 ++++
> >> >  drivers/misc/seven_seg_gpio.c                      | 206
> >> > +++++++++++++++++++++
> >> >  7 files changed, 490 insertions(+)
> >> >  create mode 100644
> >> > Documentation/devicetree/bindings/misc/seven-seg-gpio.txt
> >> >  create mode 100644 drivers/misc/seven_seg_disp.c
> >> >  create mode 100644 drivers/misc/seven_seg_disp.h
> >> >  create mode 100644 drivers/misc/seven_seg_gpio.c
> >> >
> >> > --
> >> > 2.8.0.rc3.226.g39d4020
> >> >
> >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20161213/2ff4580d/attachment.html>