<div dir="ltr">Ok. I will send this driver upstream. Thanks for the feedback.<div>I haven't looked into the proposed lpc driver. I will look at that.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 12, 2016 at 4:31 PM, Joel Stanley <span dir="ltr"><<a href="mailto:joel@jms.id.au" target="_blank">joel@jms.id.au</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Jagha,<br>
<span class=""><br>
On Tue, Dec 13, 2016 at 10:58 AM, Jaghathiswari Rankappagounder<br>
Natarajan <<a href="mailto:jaghu@google.com">jaghu@google.com</a>> wrote:<br>
> Hi Joel,<br>
> Could you please help review this patch series. Would like to have the seven<br>
> segment display driver for testing out on zaius machine.<br>
<br>
</span>I have spent a fair amount of time reading your code. It would be nice<br>
to see other developers take a look as well. Have you asked for review<br>
from your peers?<br>
<br>
> (I am trying to get the fan tach driver to work and I hope to send that a> along with pwm driver for review soon.)<br>
<br>
If you think this driver is ready to go, I suggest you send it<br>
upstream for wider community review. Same for the pwm driver. Make<br>
sure you cc me so I can help out.<br>
<span class=""><br>
> Also you had mentioned about writing the LPC driver. Is that checked in?<br>
<br>
</span>Andrew sent a proposed driver some time ago. Did you have time to review it?<br>
<br>
<a href="http://patchwork.ozlabs.org/patch/693032/" rel="noreferrer" target="_blank">http://patchwork.ozlabs.org/<wbr>patch/693032/</a><br>
<br>
I think we may prefer an ioctl based approach, but this is up for debate.<br>
<br>
Cheers,<br>
<br>
Joel<br>
<div class="HOEnZb"><div class="h5"><br>
><br>
> Thanks,<br>
> Jagha<br>
><br>
> On Tue, Nov 22, 2016 at 6:45 PM, Joel Stanley <<a href="mailto:joel@jms.id.au">joel@jms.id.au</a>> wrote:<br>
>><br>
>> We spoke on IRC about the clock changes. Lets wait until those issues<br>
>> are addressed before reviewing this series.<br>
>><br>
>> Cheers,<br>
>><br>
>> Joel<br>
>><br>
>> On Sun, Nov 20, 2016 at 5:57 PM, Jaghathiswari Rankappagounder<br>
>> Natarajan <<a href="mailto:jaghu@google.com">jaghu@google.com</a>> wrote:<br>
>> > This patchset includes:<br>
>> ><br>
>> > Documentation for the binding which provides an interface for adding<br>
>> > clock,<br>
>> > data and clear signal GPIO lines to control seven segment display.<br>
>> ><br>
>> > The platform device driver provides an API for displaying on two<br>
>> > 7-segment<br>
>> > displays, and implements the required bit-banging. The hardware assumed<br>
>> > is<br>
>> > 74HC164 wired to two 7-segment displays.<br>
>> ><br>
>> > The character device driver implements the user-space API for letting a<br>
>> > user<br>
>> > write to two 7-segment displays including any conversion methods<br>
>> > necessary<br>
>> > to map the user input to two 7-segment displays.<br>
>> ><br>
>> > Adding clock, data and clear signal GPIO lines in the devicetree to<br>
>> > control<br>
>> > seven segment display on zaius platform.<br>
>> ><br>
>> > The platform driver matches on the device tree node; the platform driver<br>
>> > also<br>
>> > initializes the character device.<br>
>> ><br>
>> > Tested that the seven segment display works properly by writing to the<br>
>> > character device file on EVB AST2500 board and on Zaius board.<br>
>> ><br>
>> > A changelog between versions is included in the individual patches.<br>
>> > Please<br>
>> > provide feedback.<br>
>> ><br>
>> > Jaghathiswari Rankappagounder Natarajan (4):<br>
>> > Documentation: dt-bindings: Document bindings for seven segment<br>
>> > display support<br>
>> > drivers: misc: Character device driver for seven segment display<br>
>> > drivers: misc: Platform driver for seven segment display support<br>
>> > arm: dts: Add dt-binding to support seven segment display on zaius<br>
>> ><br>
>> > .../devicetree/bindings/misc/<wbr>seven-seg-gpio.txt | 27 +++<br>
>> > arch/arm/boot/dts/aspeed-bmc-<wbr>opp-zaius.dts | 8 +<br>
>> > drivers/misc/Kconfig | 16 ++<br>
>> > drivers/misc/Makefile | 2 +<br>
>> > drivers/misc/seven_seg_disp.c | 197<br>
>> > ++++++++++++++++++++<br>
>> > drivers/misc/seven_seg_disp.h | 34 ++++<br>
>> > drivers/misc/seven_seg_gpio.c | 206<br>
>> > +++++++++++++++++++++<br>
>> > 7 files changed, 490 insertions(+)<br>
>> > create mode 100644<br>
>> > Documentation/devicetree/<wbr>bindings/misc/seven-seg-gpio.<wbr>txt<br>
>> > create mode 100644 drivers/misc/seven_seg_disp.c<br>
>> > create mode 100644 drivers/misc/seven_seg_disp.h<br>
>> > create mode 100644 drivers/misc/seven_seg_gpio.c<br>
>> ><br>
>> > --<br>
>> > 2.8.0.rc3.226.g39d4020<br>
>> ><br>
><br>
><br>
</div></div></blockquote></div><br></div>