[PATCH skeleton] Replace BUILD_ID with VERSION_ID in then inventory

[Adriana Kobylak]

Yes, we said we would, but I realized the inventory object only had the 
properties "present", "fault", and "version" created as default. An option 
to add the build id back would be to create a unique property for this bmc 
inventory like "build" or one like the other VPD fields like "Custom Field 
1". Thoughts?





From:   Brad Bishop <bradleyb at fuzziesquirrel.com>
To:     openbmc at lists.ozlabs.org
Date:   04/27/2016 08:11 PM
Subject:        Re: [PATCH skeleton] Replace BUILD_ID with VERSION_ID in 
then inventory
Sent by:        "openbmc" 
<openbmc-bounces+anoo=us.ibm.com at lists.ozlabs.org>



I thought we were going to expose both of these? 


> On Apr 25, 2016, at 4:20 PM, OpenBMC Patches <openbmc-patches at stwcx.xyz> 
wrote:
> 
> From: Adriana Kobylak <anoo at us.ibm.com>
> 
> Add VERSION_ID to the inventory instead of BUILD_ID because
> the version (git tag) is the value that gets updated during
> a firmware update, the build id remains constant.
> ---
> bin/inventory_items.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/bin/inventory_items.py b/bin/inventory_items.py
> index 6320f90..0a90569 100755
> --- a/bin/inventory_items.py
> +++ b/bin/inventory_items.py
> @@ -71,7 +71,7 @@ def getVersion():
>                                for line in f:
>                                                p = line.rstrip('\n')
>                                                parts = 
line.rstrip('\n').split('=')
> -                                              if (parts[0] == 
"BUILD_ID"):
> +                                              if (parts[0] == 
"VERSION_ID"):
>                                                                version = 
parts[1]
>                return version
> 
> -- 
> 2.8.1
> 
> 
> _______________________________________________
> openbmc mailing list
> openbmc at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc
_______________________________________________
openbmc mailing list
openbmc at lists.ozlabs.org
https://lists.ozlabs.org/listinfo/openbmc




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20160427/dfe66d56/attachment.html>