<font size=2 face="sans-serif">Yes, we said we would, but I realized the
inventory object only had the properties "present", "fault",
and "version" created as default. An option to add the build
id back would be to create a unique property for this bmc inventory like
"build" or one like the other VPD fields like "Custom Field
1". Thoughts?</font><br><br><br><br><br><br><font size=1 color=#5f5f5f face="sans-serif">From:      
 </font><font size=1 face="sans-serif">Brad Bishop <bradleyb@fuzziesquirrel.com></font><br><font size=1 color=#5f5f5f face="sans-serif">To:      
 </font><font size=1 face="sans-serif">openbmc@lists.ozlabs.org</font><br><font size=1 color=#5f5f5f face="sans-serif">Date:      
 </font><font size=1 face="sans-serif">04/27/2016 08:11 PM</font><br><font size=1 color=#5f5f5f face="sans-serif">Subject:    
   </font><font size=1 face="sans-serif">Re: [PATCH skeleton]
Replace BUILD_ID with VERSION_ID in then inventory</font><br><font size=1 color=#5f5f5f face="sans-serif">Sent by:    
   </font><font size=1 face="sans-serif">"openbmc"
<openbmc-bounces+anoo=us.ibm.com@lists.ozlabs.org></font><br><hr noshade><br><br><br><tt><font size=2>I thought we were going to expose both of these?  <br><br><br>> On Apr 25, 2016, at 4:20 PM, OpenBMC Patches <openbmc-patches@stwcx.xyz>
wrote:<br>> <br>> From: Adriana Kobylak <anoo@us.ibm.com><br>> <br>> Add VERSION_ID to the inventory instead of BUILD_ID because<br>> the version (git tag) is the value that gets updated during<br>> a firmware update, the build id remains constant.<br>> ---<br>> bin/inventory_items.py | 2 +-<br>> 1 file changed, 1 insertion(+), 1 deletion(-)<br>> <br>> diff --git a/bin/inventory_items.py b/bin/inventory_items.py<br>> index 6320f90..0a90569 100755<br>> --- a/bin/inventory_items.py<br>> +++ b/bin/inventory_items.py<br>> @@ -71,7 +71,7 @@ def getVersion():<br>>                  
               
for line in f:<br>>                  
               
                 p
= line.rstrip('\n')<br>>                  
               
                 parts
= line.rstrip('\n').split('=')<br>> -                
                 
               
if (parts[0] == "BUILD_ID"):<br>> +                
                 
               
if (parts[0] == "VERSION_ID"):<br>>                  
               
                 
               
version = parts[1]<br>>                  return
version<br>> <br>> -- <br>> 2.8.1<br>> <br>> <br>> _______________________________________________<br>> openbmc mailing list<br>> openbmc@lists.ozlabs.org<br>> </font></tt><a href=https://lists.ozlabs.org/listinfo/openbmc><tt><font size=2>https://lists.ozlabs.org/listinfo/openbmc</font></tt></a><tt><font size=2><br>_______________________________________________<br>openbmc mailing list<br>openbmc@lists.ozlabs.org<br></font></tt><a href=https://lists.ozlabs.org/listinfo/openbmc><tt><font size=2>https://lists.ozlabs.org/listinfo/openbmc</font></tt></a><tt><font size=2><br></font></tt><br><br><BR>