[PATCH] cell: cleanup iommu initialization

Arnd Bergmann abergman at de.ibm.com
Thu Mar 9 04:56:50 EST 2006

On Wednesday 08 March 2006 17:51, Christoph Hellwig wrote:
> On Wed, Mar 08, 2006 at 10:49:23AM -0600, Joel Schopp wrote:
> > 
> > >-    iommu->mapped_base = __ioremap(0x20000511000, 0x1000, 
> > >-    iommu->mapped_mmio_base = __ioremap(0x20000510000, 0x1000, 
> > >+    iommu->mapped_base = __ioremap(base, 0x1000, _PAGE_NO_CACHE);
> > >+    iommu->mapped_mmio_base = __ioremap(mmio_base, 0x1000, 
> > 
> > While we are cleaning this up can we name these constants.  Many of these 
> > unnamed constants throughout the patch.
> I already mentioned that in the description.  Where in the cell
> documentation could I find canonical names for these?

Hmm, the reason we did not have the base addresses here so far is that
they are set up by the firmware and therefore not really constants 
that are documented anywhere. In the new code we get them from the
device tree and the hardcoded case will go away one day when the
board that have been shipped to customers so far have all upgraded
their firmware (they need to do that anyway if they want NUMA support).

Thinking about this again, we should probably just define constants
anyway. The CBE public registers document probably names only the
offsets relative to the areas, so we need to make up names for ourselves.

	Arnd <><

More information about the Linuxppc64-dev mailing list