[PATCH] cell: cleanup iommu initialization

Christoph Hellwig hch at lst.de
Thu Mar 9 03:51:44 EST 2006


On Wed, Mar 08, 2006 at 10:49:23AM -0600, Joel Schopp wrote:
> 
> >-	iommu->mapped_base = __ioremap(0x20000511000, 0x1000, 
> >_PAGE_NO_CACHE);
> >-	iommu->mapped_mmio_base = __ioremap(0x20000510000, 0x1000, 
> >_PAGE_NO_CACHE);
> >+	iommu->mapped_base = __ioremap(base, 0x1000, _PAGE_NO_CACHE);
> >+	iommu->mapped_mmio_base = __ioremap(mmio_base, 0x1000, 
> >_PAGE_NO_CACHE);
> 
> While we are cleaning this up can we name these constants.  Many of these 
> unnamed constants throughout the patch.

I already mentioned that in the description.  Where in the cell
documentation could I find canonical names for these?



More information about the Linuxppc64-dev mailing list