[openib-general] Re: [PATCH 21/22] ehca main file

[Arnd Bergmann]

On Tuesday 21 February 2006 03:09, Heiko J Schick wrote:
>  >>+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,12)
>  >>+#define EHCA_RESOURCE_ATTR_H(name)                                         \
>  >>+static ssize_t  ehca_show_##name(struct device *dev,                       \
>  >>+                             struct device_attribute *attr,            \
>  >>+                             char *buf)
>  >>+#else
>  >>+#define EHCA_RESOURCE_ATTR_H(name)                                         \
>  >>+static ssize_t  ehca_show_##name(struct device *dev,                       \
>  >>+                             char *buf)
>  >>+#endif
>  >
>  >
>  > No need for kernel version ifdefs.
> 
> The point is that our module have to run on Linux 2.6.5-7.244 (SuSE SLES 9 SP3), too.
> This was the reason why we've included the ifdefs. We can change the ifdefs to
> #if LINUX_VERSION_CODE >= KERNEL_VERSION(2.6.5) to mark that this code is used for
> Linux 2.6.5 compatibility.

That only makes sense as long as you have a common source code for both
that also is under your control. As soon as the driver enters the mainline
kernel, it is no longer helpful to have these checks in it, because other
people will start making changes to the driver that you don't want to
have in the 2.6.5 version.

You cannot avoid forking the code in the long term, but fortunately the
need to backport fixes to the old version should also decrease over time.

	Arnd <><