[PATCH] kdump ppc64: fix htab-size for non-lpar

[Michael Ellerman]

On Fri, 17 Feb 2006 09:11, Olof Johansson wrote:
> On Fri, Feb 17, 2006 at 08:56:49AM +1100, Michael Ellerman wrote:
> > On Fri, 17 Feb 2006 01:26, Olof Johansson wrote:
> > > On Thu, Feb 16, 2006 at 07:45:06PM +0530, R Sharada wrote:
> > > > Hello,
> > > > 	The htab-size calculated for kexec/kdump on 2.6 kernels was broken,
> > > > leading to wrong value being exported to /proc/device-tree
> > > > Here is a patch fixing it up.
> > >
> > > Why you don't use htab_hash_mask in kexec instead of introducing a
> > > global variable?
> >
> > Separation of concerns? We currently do the calculation in the kexec
> > code, but that's gotten out of sync with the htab code, so just do it in
> > one place and export it.
>
> Eh, it's not like the hash group size is likely to change anytime soon,
> given that it's fixed in the architecture. But sure, it avoids exposing
> knowledge of it to kexec.

Yeah sure, it's possible we could change the meaning of htab_hash_mask in 
future, although I agree it's unlikely.

> That looks considerably better. No more complaints from me. :)

Cool, I'll get it tested and send it up.

cheers

-- 
Michael Ellerman
IBM OzLabs

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://ozlabs.org/pipermail/linuxppc64-dev/attachments/20060217/73e6fbf4/attachment.pgp