[PATCH] kdump ppc64: fix htab-size for non-lpar

[Olof Johansson]

On Fri, Feb 17, 2006 at 08:56:49AM +1100, Michael Ellerman wrote:
> On Fri, 17 Feb 2006 01:26, Olof Johansson wrote:
> > On Thu, Feb 16, 2006 at 07:45:06PM +0530, R Sharada wrote:
> > > Hello,
> > > 	The htab-size calculated for kexec/kdump on 2.6 kernels was broken,
> > > leading to wrong value being exported to /proc/device-tree
> > > Here is a patch fixing it up.
> >
> > Why you don't use htab_hash_mask in kexec instead of introducing a
> > global variable?
> 
> Separation of concerns? We currently do the calculation in the kexec code, but 
> that's gotten out of sync with the htab code, so just do it in one place and 
> export it.

Eh, it's not like the hash group size is likely to change anytime soon,
given that it's fixed in the architecture. But sure, it avoids exposing
knowledge of it to kexec.

> > Saves a new global and a bunch of #ifdefs.
> 
> I agree the patch could be a bit simpler, eg (totally untested):

That looks considerably better. No more complaints from me. :)


-Olof